Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s-meta): Disable plugin management from the UI #152

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

renaudhager
Copy link
Contributor

@renaudhager renaudhager commented Jan 20, 2025

This pull request includes a small change to the shopware/k8s-meta/1.0/config/packages/operator.yaml file. The change adds a new configuration option for runtime_extension_management under the deployment section (see documentation)

@renaudhager renaudhager added the enhancement New feature or request label Jan 20, 2025
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Add the Shopware flex endpoint in your composer.json to https://raw.githubusercontent.com/shopware/recipes/flex/pull-152/index.json.

    # When jq is installed
    jq '.extra.symfony.endpoint |= [ "https://raw.githubusercontent.com/shopware/recipes/flex/pull-152/index.json" ] + .' composer.json > composer.tmp && mv composer.tmp composer.json

    or manually

    "endpoint": [
        "https://raw.githubusercontent.com/shopware/recipes/flex/pull-152/index.json",
        "https://raw.githubusercontent.com/shopware/recipes/flex/main/index.json",
        "flex://defaults"
    ]
  2. Install the package(s) related to this recipe:

    composer req 'shopware/k8s-meta:^1.0'

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@msestendrup
Copy link

I added this issue to our Infrastructure project and assigned it to the Q1 iteration.

@msestendrup
Copy link

For the record - why we need this:

  • It would make it clearer and reduce future support requests.
    • If someone installs a plugin from the admin dashboard, the code of the plugin will not be correctly deployed, and after certain amount of time (when all pods get recycled) the code of this plugin is gone, the only things left would be any data in the DB.
  • Customers who create support tickets for an external plugin manufacturer. When the external plugin manufacturer wants access to his shop to debug and look into the Administration of the shop they don't know that they can't use the UI action buttons.

@shyim shyim merged commit e9ed8e6 into main Jan 20, 2025
2 checks passed
@shyim shyim deleted the feat/disable-plugin-management-k8s-meta branch January 20, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants